Change in ovirt-engine[master]: core: task manager cache is not cleared..(#854308)
Eli Mesika has submitted this change and it was merged.
Change subject: core: task manager cache is not cleared..(#854308)
......................................................................
core: task manager cache is not cleared..(#854308)
task manager cache is not cleared after getting error that task does not exist from vdsm
on stopTask(#854308)
This patch insures that async tasks found in engine and not found by
VDSM will get the 'unknown' state.
The case in which there may be no SPM temporally as a result of a
failure is handled differently in AsyncTaskManager and
SPMGetAllTasksStatusesVDSCommand.
Previous code sets all tasks that are found by engine (in cache) and not
found as VDSM as running. This prevented cleanup of unknown tasks from
the cache as described in BZ.
https://bugzilla.redhat.com/854308
Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11e
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksStatusesVDSCommand.java
3 files changed, 15 insertions(+), 19 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>