Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: validation error on create template
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal,webadmin: validation error on create template
......................................................................
userportal,webadmin: validation error on create template
It was not possible to create a new template. The problem was that:
- UnitVmModel.validate() did not pass the CPU validation: new
IntegerValidation(1, behavior.maxCpus) because the behavior.maxCpus was not
inited.
- the behavior.maxCpus was not inited because it is inited in the
VmModelBehaviorBase.updateMaxNumOfVmCpus() which is called which is triggered
by calling the VmModelBehaviorBase.updateNumOfSockets() which is supposed to
be called from the specific behavior classes'
postDataCenterWithClusterSelectedItemChanged.
- The problem was that the
NewTemplateVmModelBehavior.postDataCenterWithClusterSelectedItemChanged
did not called the updateNumOfSockets()
Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf
Bug-Url: https://bugzilla.redhat.com/1085754
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server