Change in ovirt-engine[master]: userportal, webadmin: add element ids to vm general subtab
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: add element ids to vm general subtab
......................................................................
userportal, webadmin: add element ids to vm general subtab
Added element ids to the vm general subtab -- every row, every column in the form.
The ids will have the format unique-prefix_rowX_colX_label and
unique-prefix_rowX_colX_value.
Also added some infrastructure to easily add ids to all of the sub-tab form views.
Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundFormWidget.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java
4 files changed, 48 insertions(+), 1 deletion(-)
Approvals:
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server