Change in ovirt-engine[master]: core: Create PairQueryable ID without UUID serialization
Lior Vernia has submitted this change and it was merged.
Change subject: core: Create PairQueryable ID without UUID serialization
......................................................................
core: Create PairQueryable ID without UUID serialization
As it turns out, serializing a UUID is a resource-consuming operation,
and is not in fact required to compute a unique ID for a PairQueryable
object. The mechanism is therefore swapped for a more efficient one,
while maintaining the form of the serialized ID (in case it is needed
somewhere, though that does not seem to be the case).
The new ID is represented by a new class PairQueryableId which isn't
but a Pair of objects - the corresponding IDs of the PairQueryable
members. PairQueryableId.toString() maintains the serialized form
previously returned from getQueryableId(): "ID1.ID2" (as opposed to
the standard Pair serialization).
Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b
Bug-Url: https://bugzilla.redhat.com/1123396
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java
2 files changed, 29 insertions(+), 6 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/35198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server