Change in ovirt-engine[master]: dashboard: Optimize VM status query
Alexander Wels has submitted this change and it was merged.
Change subject: dashboard: Optimize VM status query
......................................................................
dashboard: Optimize VM status query
- the vm_samples_history table will grow significantly every
minute (number of VMs each time). This made the original
query slow as it needs to go through the entire table to
lookup the right history_id. I modified the query to first
filter on time frame, and then select the latest history_id
from the filtered set. The query now takes < 100ms.
- Made similar changes to the top 10 cpu/mem/storage vm lookup
to filter by timeframe as significantly reducing the query time.
- Verified all other queries are fast in a scale environment.
- Note all the queries are using the DWH views and one of those
views is missing an index on vm_id and history_datetime. These
will not be fast unless that index is added.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345934
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345947
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345944
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344428
Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties
M
frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.properties
2 files changed, 73 insertions(+), 68 deletions(-)
Approvals:
Shirly Radco: Looks good to me, but someone else must approve
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>