Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (6/6)
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: DataProvider.java cleanup (6/6)
......................................................................
webadmin: DataProvider.java cleanup (6/6)
DataProvider is a class which is mostly obsolete,
as it contains synchronous calls to the engine,
which are not relevant anymore under the GWT platform/infrastructure.
The goal is to eliminate this class all-together.
In this patch:
1) Removing sync getUsers and not replacing it;
The original flow was to get all users, and filter
out users that are already included.
This filtering needs further thinking,
beacuse the admins may be confused by it (e.g. empty list)
2) Deleting DataProvider.java since it's now empty
Change-Id: I31f6af5b3af32a55a623ce701c2a6c384bef6ddc
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/881747
---
D
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
2 files changed, 0 insertions(+), 37 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31f6af5b3af32a55a623ce701c2a6c384bef6ddc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>