Tal Nisan has submitted this change and it was merged.
Change subject: engine: Attach/Detach two (or more) nets with labels to cluster fails
......................................................................
engine: Attach/Detach two (or more) nets with labels to cluster fails
When more than one network with a label are attached/detached to/from a
cluster via multiple action- Attach/DetachNetworkToVdsGroup an internal
command Attach/DetachNetworksFromCluster is called.
Due to changes in internal commands protocol- commands that are called
internally should have two ctors-
1. Ctor(T parameters)
2. Ctor(T parameters, CommandContext cmdContext)
Since the Attach/DetachNetworkToVdsGroup didn't have the first ctor there
was an exception.
Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68
Bug-Url:
https://bugzilla.redhat.com/1124392
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit a6ed2fe0a0aec332d2ed66b9536e8988c767157a)
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/30793
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server