Change in ovirt-engine[master]: engine: enabling StopRemoveBrick when data migration is comp...
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: enabling StopRemoveBrick when data migration is completed
......................................................................
engine: enabling StopRemoveBrick when data migration is completed
Changei canDoAction to allow Stop Remove brick to be called even when the
task is finished( data migration complete). This helps to implement
the Retain Bricks UI command. Also change the remove-brick step status
to ABORTED.
changing the step status from FINISHED to ABORTED is not allowed through
Step.markStepEnded. Hence explicitly update the status and endtime in
GlusterAsyncCommand.endStepJob.
Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java
3 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/20110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server