Change in ovirt-engine[master]: core: Additional null checks in VmDeviceUtils
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Additional null checks in VmDeviceUtils
......................................................................
core: Additional null checks in VmDeviceUtils
Added null checks that were missing after refactoring VmDeviceUtils.
* In updateBootOrder() vm may be null if the method is called with ID of
a template.
* In getVmDevicesForNextRun() return value of
findVmDeviceBy[General]Type() may be null.
Change-Id: Ibd3574905fa4dd58e31cd914f4124e7a435c9ee9
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 19 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd3574905fa4dd58e31cd914f4124e7a435c9ee9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org