Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup in ovf readers
......................................................................
core: cleanup in ovf readers
- Changed OvfReader#readVmDevice so it will only create VmDevice from
the given XML node
- Introduced two new methods, one for reading managed device and another
one for reading unmanaged device
- Extracted the code that adds a given managed VmDevice to separate
method, addManagedVmDevice (this method will be used in later patches)
Change-Id: I01133cc483252683893d79d403c29aabff6701f5
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
3 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
http://gerrit.ovirt.org/29842
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01133cc483252683893d79d403c29aabff6701f5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server