Change in ovirt-engine[ovirt-engine-3.3]: engine: Change backward compatibility logic for add/update vnic
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Change backward compatibility logic for add/update vnic
......................................................................
engine: Change backward compatibility logic for add/update vnic
The current backward compatibility logic designed for
resolving a vnic profile id for a given network should
be modified, since REST clients which provides both
network name and vnic profile id might face issues, such
ignoring the vnic profile id.
For that purpose the engine will attempt to find a change
in the network name provided by the user to what is already
configured on the vnic:
1. If network name is provided, and unchanged - the vnic
profile id from the parameters is used.
2. If the network name is provided and changed, use it
instead of the vnic profile id.
Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75
Bug-Url: https://bugzilla.redhat.com/1064823
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java
5 files changed, 55 insertions(+), 11 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server