4:07 a.m.
Martin Peřina has submitted this change and it was merged.
Change subject: core: utils: print path of constraint violation in validation
......................................................................
core: utils: print path of constraint violation in validation
Log:
WARN [org.ovirt.engine.core.bll.network.dc.AddNetworkCommand]
(default task-43) [5507170a] Validation of action 'AddNetwork'
failed for user admin@internal-authz.
Reasons: VAR__TYPE__NETWORK,VAR__ACTION__ADD,MTU_VALUE_INVALID,
ACTION_TYPE_FAILED_ATTRIBUTE_PATH,$path network.mtu
ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource]
(default task-43) [] Operation Failed:
[mtu value invalid, Attribute: network.mtu]
REST API:
<?xml version="1.0" encoding="UTF-8"
standalone="yes"?>
<fault>
<detail>[mtu value invalid, Attribute: network.mtu]</detail>
<reason>Operation Failed</reason>
</fault>
UI Error:
Error while executing action:
nic:
* Name must be formed of alphanumeric characters, numbers or "-_.".
* Attribute: nic.name
Change-Id: I3f4c2978913af7f0f9348c480c705c2cdc917627
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1295678
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f4c2978913af7f0f9348c480c705c2cdc917627
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>