Change in ovirt-engine[ovirt-engine-4.0]: core: Fix creation of diskless snapshot without memory
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix creation of diskless snapshot without memory
......................................................................
core: Fix creation of diskless snapshot without memory
When creating a snapshot without memory the snapshot is created
initially in OK status while relying on the fact that no async
operations will run and the command won't reach the endAction()
phase.
When using the ConcurrentChildCommandsExecutionCallback, the
command will always reach the endAction() method.
This patch removes duplicated code between the execute() and the
endAction() while adapting the endAction() to handle a snapshots
which contains only configuration.
Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701
Bug-Url: https://bugzilla.redhat.com/1342110
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
1 file changed, 13 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58634
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>