Change in ovirt-engine[master]: core: Remove checkImagesLocked(vmId, messages)
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove checkImagesLocked(vmId, messages)
......................................................................
core: Remove checkImagesLocked(vmId, messages)
Removed ImagesHandler.checkImagesLocked(Guid vmId, List<String
messages), as ImagesHandler should not know about VMs.
Wherever it was used (two places - AddVmFromSnapshot and
LiveMigrateVmDisks), it was replaced with a direct call to DiskDao and
then a simpler call to
ImagesHandler.checkImagesLocked (messages, disks).
Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
3 files changed, 11 insertions(+), 15 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>