Change in ovirt-engine[master]: engine: Edit Pool shows different RAM than defined (#833829)
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
......................................................................
engine: Edit Pool shows different RAM than defined (#833829)
https://bugzilla.redhat.com/833829
Have a template X with 256 MB memory, than:
Pools->New->select template X->change RAM to 512 MB->save
Than select the newly created pool and Edit.
The memory will be 256 MB.
The problem was, that both the
(New/Existing)PoolModelBehavior classes let the filling of the
window model to the parent class (PoolModelBehaviorBase) which
used the template. It is correct for the
NewPoolModelBehavior but not for the ExistingPoolModelBehavior.
Fixed by generalizing the logic of setting up the window model
to take VmBase instead of VmTemplate and calling this from the
specific classes (New/Existing)PoolModelBehavior with the
correct parameter.
Change-Id: I7fbc3774cdf4ed4209724fd8d5053bbef0a76f7b
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
6 files changed, 83 insertions(+), 45 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6459
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fbc3774cdf4ed4209724fd8d5053bbef0a76f7b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>