Change in ovirt-engine[master]: core: invalid equality comparison

Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80539 ) Change subject: core: invalid equality comparison ...................................................................... core: invalid equality comparison operands being compared aren't primitives not interned strings, thus they must not be compared using != operator, and equals have to be used instead. Explanation why this fails the bug: mac pool wasn't changed during cluster update, thus this cluster must be sorted out from further processing. But because of mistake, mac pool ids were compared using identity check, which incorrectly yield, that both macs are different, while they are not. Change-Id: Ia504ee004f879369a8edd1e1d99b55e45ec29840 Bug-Url: https://bugzilla.redhat.com/1480238 Signed-off-by: Martin Mucha <mmucha(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia504ee004f879369a8edd1e1d99b55e45ec29840 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt; Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;