Change in ovirt-engine[master]: findbugs: Clean up Dubious Method warnings
Eli Mesika has submitted this change and it was merged.
Change subject: findbugs: Clean up Dubious Method warnings
......................................................................
findbugs: Clean up Dubious Method warnings
Findbugs' Dubious Method Used warning are about calling methods that
would work, but perform the required task inefficiently (e.g., calling
new Boolean(true) instead of Boolean.valueOf(true), or even
Boolean.TRUE).
This patch removes the all-out filter for this category of warnings.
Issues previously suppressed by this filter are either fixed where
possible, or replaced with a more fine-grained filter where not
possible.
A notable case where these issues cannot be fixed in is GWT's
auto-generated hashCode() methods for classes containing a boolean
member.
Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
M exclude-filters-general.xml
M frontend/webadmin/modules/frontend/exclude-filters.xml
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java
M frontend/webadmin/modules/webadmin/exclude-filters.xml
7 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/26473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server