From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: remove old luns from db on sd sync
......................................................................
backend: remove old luns from db on sd sync
This patch removes the method cleanupLunsFromDb and instead wraps its
logic inside a LunUpdateHandler object, just like when updating or
saving new luns.
It also fixes a bug where luns are being removed only if new or existing
and not up to date luns were found.
That is, we now always check if old luns exist and then remove them.
Change-Id: Ia95a44ef269a5daecf71a2bddfa813919d179ca6
Bug-Url:
https://bugzilla.redhat.com/1439692
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java
2 files changed, 71 insertions(+), 34 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/77074
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia95a44ef269a5daecf71a2bddfa813919d179ca6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>