Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Add UI field for Neutron physical network
......................................................................
webadmin: Add UI field for Neutron physical network
The same UI field was being used for both the oVirt label and the
Neutron physical network, and only its interpretation changed
according to context, which was confusing.
As usual, had to change some styling for things to look decent (some
of it is related to unresolved Look & Feel feature issues).
Change-Id: I6b90800cf5948b35283bef03d8e2f95384799c80
Bug-Url:
https://bugzilla.redhat.com/1108069
Bug-Url:
https://bugzilla.redhat.com/1121546
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
6 files changed, 46 insertions(+), 53 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/31667
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b90800cf5948b35283bef03d8e2f95384799c80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server