Change in ovirt-engine[ovirt-engine-3.5]: core: Add space validation when creating snapshot
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add space validation when creating snapshot
......................................................................
core: Add space validation when creating snapshot
In CreateAllSnapshotsFromVmCommand, added to CDA missing storage space validations.
For that, added allDomainsHaveSpaceForNewDisks to
MultipleStorageDomainsValidator .
Added relevant tests.
Change-Id: I0a5b5df695d30a34fbdef31da2320b322e27466b
Bug-Url: https://bugzilla.redhat.com/1053752
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java
4 files changed, 118 insertions(+), 8 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/30056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5b5df695d30a34fbdef31da2320b322e27466b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server