Change in ovirt-engine[master]: core: Change cluster command should lock host
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Change cluster command should lock host
......................................................................
core: Change cluster command should lock host
This patch adds a missing lock when host cluster is changed.
Prior to this change the host was not locked allowing a concurrent
removal of the host to occur while the change cluster operation is still
running this resulted on a SQL exception while trying to add a line to
host SPM mapping table with a host GUID when the host was already
removed.
Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102729
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org