Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused Tag methods and classes
......................................................................
core: Remove unused Tag methods and classes
Removed the unused methods getAllUserGroupTagsWithIds(String),
getAllForVdsWithIds(String) and
getVmPoolTagsByVmPoolIdAndAdElementId(Guid, Guid) from TagDao and its
implementation, as well as the backing stored procedures that serve
these methods.
getVmPoolTagsByVmPoolIdAndAdElementId was the only place in the codebase
to use TagsVmPoolMap, so it was also removed. Once that was removed,
TagsVmPoolMapId also became redundant, and was removed as well.
Change-Id: I120f3c6f4f89e85887593d5ff87c7f529551e257
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMap.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMapId.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDaoImpl.java
M packaging/dbscripts/tags_sp.sql
5 files changed, 0 insertions(+), 165 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/50613
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I120f3c6f4f89e85887593d5ff87c7f529551e257
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>