Change in ovirt-engine[master]: utils: ssh: move to member '_' convention
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: move to member '_' convention
......................................................................
utils: ssh: move to member '_' convention
We had several discussion over this.
Convention for members/static/globals is very helpful when dealing with
patch hunk and review, as every variable can be assigned to proper
context without reading the whole code.
It also avoid naming clashes between the different scope level.
I am aware that some people are not used to variable name convention,
however it is much easier to maintain and review patches in this mode.
I am enforcing this convention on bootstrap and ssh sources, and I hope
that others will see the benefit in this method as well.
Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
4 files changed, 76 insertions(+), 76 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>