Change in ovirt-engine[master]: webadmin: Use Long.compare instead of boxing
Juan Hernandez has submitted this change and it was merged.
Change subject: webadmin: Use Long.compare instead of boxing
......................................................................
webadmin: Use Long.compare instead of boxing
This is necessary to avoid the following findbugs error:
Boxing a primitive to compare
A boxed primitive is created just to call compareTo method. It's more
efficient to use static compare method (for double and float since Java
1.4, for other primitive types since Java 1.7) which works on primitives
directly.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_COMPARE
Change-Id: I373b33659ad517525f1b1056469262772cdfbbcb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Alexander Wels: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I373b33659ad517525f1b1056469262772cdfbbcb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org