Eli Mesika has submitted this change and it was merged.
Change subject: core: comma separated list of values in search
......................................................................
core: comma separated list of values in search
Add metadata in search engine that enables to support column values that
actually includes comma separated lists of values
For example, if a ISO storage is attached to 2 DCs : dc1 and dc2 then in
the storage_domains_for_search view the column datacenter value is
"dc1,dc2" , current search syntax will search for 'dc1' or 'dc2'
from
the tree view and will give no results.
The same applies for a disk that is shared by 2 VMs vm2 and vm2 when searching from
the disk tab for vm_names with 'vm1' or 'vm2'
This patch adds an option to add metadata that enabled to define per
table/view a list of columns that have actually comma separated values
as "dc1,dc2" or "vm1,vm2" in the examples above.
Once this metadata is added, the search engine will build the proper SQL
to match any of the comma separated values.
Change-Id: Ie0fa048b1d12392f1c1ea81ed720be6c4078f7d0
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1320774
Signed-off-by: emesika <emesika(a)redhat.com>
---
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
6 files changed, 45 insertions(+), 9 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/59123
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0fa048b1d12392f1c1ea81ed720be6c4078f7d0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>