Change in ovirt-engine[ovirt-engine-4.0]: core: log reason for stopping vm only if set
Tal Nisan has submitted this change and it was merged.
Change subject: core: log reason for stopping vm only if set
......................................................................
core: log reason for stopping vm only if set
Previously we always tried to include the stop reason when auditing
VM stop operation. When no reason was set, either because it is not
enabled in the cluster or the user simply did not enter a reason,
the audit log included the following redundant message:
(Reason: No reason was returned for this operation failure.
See logs for further details.)
This patch changes that so audit logs will include the stop reason
only when it is set. That way, we avoid messages as shown above.
Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d
Bug-Url: https://bugzilla.redhat.com/1340414
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 13 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/63051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>