From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase
......................................................................
core: AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase
Extract a common base class,
AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase to
hold the shared logic from
GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest,
GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest and
GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.
Change-Id: I7cbdb468229c284e498b8c790683ee0f10548c2d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
4 files changed, 172 insertions(+), 375 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/70251
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cbdb468229c284e498b8c790683ee0f10548c2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>