Change in ovirt-engine[master]: core: Handle NUMA preferred tune mode
Roy Golan has submitted this change and it was merged.
Change subject: core: Handle NUMA preferred tune mode
......................................................................
core: Handle NUMA preferred tune mode
This patch addresses 3 issues:
- 5892ef11 added NumaTuneMode to VmBase, so we need to update all
VmStatic elements (VM templates) that was added since.
- libvirt failure when running in preferred mode without specifying
numa nodes. Added validation to add/edit VM to fail command when preferred
numa tune set and there is no single VM node configured pinned to NUMA
node.
Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Bug-Url: https://bugzilla.redhat.com/1146445
Bug-Url: https://bugzilla.redhat.com/1147261
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
A
packaging/dbscripts/upgrade/03_06_0420_set_interleave_default_value_for_numa_tune_mode.sql
8 files changed, 58 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server