Change in ovirt-engine[master]: upload stream fails due to explicit cast
Eli Mesika has submitted this change and it was merged.
Change subject: upload stream fails due to explicit cast
......................................................................
upload stream fails due to explicit cast
Code assumes that we all the time use xmlrpc and explicitly casts it to
VdsServerWrapper to get http client. When host uses jsonrpc it fails
with class cast excpetion.
This patch uses existing code to build http client and passes it to
JsonRpcVdsServer implementation. getHttpClient method is promoted to
IVdsServer interface so jsonrpc implementation can expose http client as
well.
Bug-Url: https://bugzilla.redhat.com/1138986
Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
5 files changed, 20 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server