Arik Hadas has submitted this change and it was merged.
Change subject: core: fix detection of external VMs
......................................................................
core: fix detection of external VMs
The recently added cache of static VM data lead of NPE when
externally managed VMs are detected. This patch solves it
by adding protection for the NPE and update the cache data
in VmManager when adding externally managed VMs.
Change-Id: I6a2af4f5cf3068d19a268239911f086d096b6281
Bug-Url:
https://bugzilla.redhat.com/1368817
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit
https://gerrit.ovirt.org/63639
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a2af4f5cf3068d19a268239911f086d096b6281
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>