Change in ovirt-engine[ovirt-engine-3.6]: webadmin: edit pool dialog not load when the DC is not up
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: edit pool dialog not load when the DC is not up
......................................................................
webadmin: edit pool dialog not load when the DC is not up
The problem was that the PoolListModel started the progress by directly calling
startProgress() wich is not good - it has to be handled by the infrastructure
(e.g. AbstractModelBoundPopupPresenterWidget is handling the start/stop
progress according to the AsyncOperation[Started/Completed]Event.
Other fix needed was a null check on the spiceProxyEnabled since the model is
not inited completely when the DC is not active.
Change-Id: I8177155885dfb4c64785b905db614bc6b4ffe44a
Bug-Url: https://bugzilla.redhat.com/1245599
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Tal Nisan: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45090
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8177155885dfb4c64785b905db614bc6b4ffe44a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org