Change in ovirt-engine[master]: core: error in calculating number of available macs / trimmi...
Lior Vernia has submitted this change and it was merged.
Change subject: core: error in calculating number of available macs / trimming mac pool
ranges
......................................................................
core: error in calculating number of available macs / trimming mac pool ranges
mac ranges was trimmed to inapproriate size; it was trimmed so that
first and last mac representation can 'fit' into int datatype, but
that rendered unable to fit *count* of macs in such range into int
datatype, since that count would then be max_int+1 and that'd cause
overflow.
Bug-Url: https://bugzilla.redhat.com/1162077
Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/Range.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/RangeTest.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java
4 files changed, 36 insertions(+), 4 deletions(-)
Approvals:
Martin Mucha: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server