Change in ovirt-engine[ovirt-engine-3.5]: engine: Edit disk description when VM is up
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Edit disk description when VM is up
......................................................................
engine: Edit disk description when VM is up
Since the description is just a database field, there's no (good)
reason to prevent editing disks' descriptions while the related VM(s)
is(are) up.
This patch includes:
- Fixing the UpdateVmDiskCommand to allow such updates
- Adding cases to UpdateVmDiskCommandTest to check this functionality
- Fixing EditDiskModel to allow this update in the UI
Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
3 files changed, 30 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/30501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server