From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Don't generate custom tarball
......................................................................
Don't generate custom tarball
Currently the SDK generates a tarball using the 'tar' command
explicitly. This tarball is different to the one generated by the
distutils 'sdist' command (which is also executed as part of the build).
To avoid differences between the files published in the oVirt web site
and the files published in PyPI, this patch changes the automation
scripts so that this custom tarball is replaced by the tarball generated
by the 'sdist' command. In addition, and in order to achieve that, the
patch also changes the way that the version numbers of the SDK are
generated, so that they follow the advices of PEP440. Note that these
changes in version numbers only apply to non release builds, release
builds already used PEP440 version numbers.
Change-Id: I8febc38acb3980ea78229ba384f1140273866a86
Bug-Url:
https://bugzilla.redhat.com/1422979
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M automation/build.py
M packaging/spec.el7.in
M packaging/spec.fc24.in
M packaging/spec.fc25.in
M sdk/MANIFEST.in
5 files changed, 32 insertions(+), 29 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/72468
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8febc38acb3980ea78229ba384f1140273866a86
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>