Omer Frenkel has submitted this change and it was merged.
Change subject: uutils: OpenSSHUtils: enable multi-key validation
......................................................................
uutils: OpenSSHUtils: enable multi-key validation
for single key the current implementation is not good as it ignores
everything after the 2nd field, ignoring new line terminator of key.
as we already support multiple keys, we just need to verify each line as
a key.
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1223671
Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
M
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
3 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/46260
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org