Change in ovirt-engine[master]: core: get cd path only when the VM isn't the hosted engine
Omer Frenkel has submitted this change and it was merged.
Change subject: core: get cd path only when the VM isn't the hosted engine
......................................................................
core: get cd path only when the VM isn't the hosted engine
When the VM we wish to change disk to is the hosted engine VM, getting
the CD path fails, as this VM isn't managed by the engine.
For that reason, this patch moves this logic to after we know it is not
the hosted engine. In addition, it is good to do that not in the
constructor but after some validation is done, as it is less error
prone.
Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3
Bug-Url: https://bugzilla.redhat.com/1014030
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server