Change in ovirt-engine[master]: webadmin: Bypassing findbugs issue of incorrect lazy initial...
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Bypassing findbugs issue of incorrect lazy initialization.
......................................................................
webadmin: Bypassing findbugs issue of incorrect lazy initialization.
Findbug is referencing a potential threading issue where in a multi
thread environment, there would be potential situation where the lazy
initialization of windowsOsTypes in AsyncDataProvider:getWindowsOsTypes()
will creat more than once instnace.
With GWT, synchronizing the method has no meaning except
bypassing findbugs warning as the code compiles to
javascript and is executed in single thread anyway.
Change-Id: I599d8418bf6e326564354e6173603fd974af1a7a
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I599d8418bf6e326564354e6173603fd974af1a7a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>