Change in ovirt-engine[master]: engine: Simplify HostValidator hierarchy and cover with tests
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Simplify HostValidator hierarchy and cover with tests
......................................................................
engine: Simplify HostValidator hierarchy and cover with tests
There isn't a good reason for UpgradeHostValidator to extend
HostValidator. It also deserves its testing.
Change-Id: I2f7e396e6523010d1deda9213de70beeaa38c074
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java
5 files changed, 138 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f7e396e6523010d1deda9213de70beeaa38c074
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org