Change in ovirt-engine[ovirt-engine-3.3.1]: core: allow identical path for different local domains
Itamar Heim has submitted this change and it was merged.
Change subject: core: allow identical path for different local domains
......................................................................
core: allow identical path for different local domains
StorageServerConnectionCommandBase -> isConnWithSameDetailsExists:
Added a specific validation for local domains connections;
allowing identical path for local domains residing
on different data-centers.
Note: as a future work, we should add a unique identification
for a local domains connections (e.g. to differentiate between
local connections retrieved from the rest-api).
Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Bug-Url: https://bugzilla.redhat.com/1023739
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
5 files changed, 87 insertions(+), 25 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.1
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>