Change in ovirt-engine[ovirt-engine-3.5]: engine: validate (vm NUMA nodes) <= (vm CPU cores)
Tal Nisan has submitted this change and it was merged.
Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores)
......................................................................
engine: validate (vm NUMA nodes) <= (vm CPU cores)
Add validation in canDoAction(), in UpdateVmCommand.
Validate (vm NUMA nodes> <= (vm CPU cores), even if called from REST api
Generate a detailed error message:
[Cannot edit VM. Assigned 2 NUMA nodes for 1 CPU cores. Cannot assign
more NUMA nodes then CPU cores.]
Bug-Url: https://bugzilla.redhat.com/1220122
Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 66 insertions(+), 2 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org