From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: add default role among network roles List
......................................................................
core: add default role among network roles List
method isRoleNetwork decide, whether given NetworkCluster denotes
'NetwrokRole', and only such instances are validated. DefaultRoute
should be part of this validation, thus this method must return true
for this NetworkCluster instances.
Validation will now require, that all new or modified network
attachments passed into HostSetupNetworksCommand with DefaultRoute
role will have non-null ipconfiguration with set primary address and
static or dhcp boot protocol.
Change-Id: I97a398f91c378cdd2afe2dcb7c04cf79351516ce
Bug-Url:
https://bugzilla.redhat.com/1438445
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
2 files changed, 6 insertions(+), 8 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/76497
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97a398f91c378cdd2afe2dcb7c04cf79351516ce
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>