Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove notYetRemoved condition from removeTemplateImages.
......................................................................
core: Remove notYetRemoved condition from removeTemplateImages.
RemoveAllVmTemplateImageTemplatesCommand behaviour should be alligned
with RemoveAllVmImagesCommand regarding the deletion of notYetRemoved
flag which was introduced at commit 03abfef3798e026b5c4eb431b08724d5f46205de.
RemoveAllVmTemplateImageTemplatesCommand shouldn't fail in case of
failure to create a task for deletion.
The engine should continue and try to delete the other
images
Change-Id: Iaa2051252cbc9a270102717787249e8885573290
Bug-Url:
https://bugzilla.redhat.com/1328071
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/57033
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa2051252cbc9a270102717787249e8885573290
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>