Change in ovirt-engine[master]: engine: Adjust SetupNetworks to accept any vlan device name
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjust SetupNetworks to accept any vlan device name
......................................................................
engine: Adjust SetupNetworks to accept any vlan device name
Changes done in this patch-
1. SetupNetworks uses iface.getBaseInterface() and iface.getVlanId()
instead of determining this values from the vlan device name (since its
format is no longer- baseIface.vlanId).
2. SetupNetworks uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).
Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
4 files changed, 47 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server