Change in ovirt-engine[master]: core: avoid update disk dynamic data gathered from disk snap...
Liron Ar has submitted this change and it was merged.
Change subject: core: avoid update disk dynamic data gathered from disk snapshot
......................................................................
core: avoid update disk dynamic data gathered from disk snapshot
When a disk snapshot is plugged to the vm, a transient image is created on the
host local storage to allow read/write to that plugged 'disk'.
Therefore when the disk related stats are recieved for a VM that a disk snapshot
is plugged to, they shouldn't be updated in the disc_image_dynamic table.
The update is avoided at the DB level as we are trying to reduce the
number of the queries in VdsUpdateRuntimeInfo (in oppose to load the
device from the db and perform the check in the engine).
Change-Id: Iaa25d040327b4cfe9b049fa2ec2638893190e8ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110830
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M packaging/dbscripts/disk_image_dynamic_sp.sql
9 files changed, 98 insertions(+), 30 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa25d040327b4cfe9b049fa2ec2638893190e8ef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server