Change in mom[master]: vdsm xml rpc: fix locking
Adam Litke has submitted this change and it was merged.
Change subject: vdsm xml rpc: fix locking
......................................................................
vdsm xml rpc: fix locking
Multiple threads will call concurrently the hypervisor interface.
Without proper locking, we will have races. The most noticeable
effect is an unbounded amount of calls to VDSM, due to the raceful
age check. This completely defeats the purpose of caching.
This patch adds a lock to make sure the check is safe, and that
the caching is effective.
Change-Id: I8a6d058ee2631bd100153c2091400a2a35b4fb1d
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42574
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/42574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a6d058ee2631bd100153c2091400a2a35b4fb1d
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org