12:52 p.m.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetVGList*
......................................................................
core: Remove GetVGList*
GetVGList query returns all the VGs a host can access that are not
correlated to storage domains saved in the database. It is only used in
BackendHostStorageResource, where it is used to retrieve connection
information. This information is redundant, as it's always used together
with the connections related to GetDeviceList, which retrieves devices
related to VGs too, anyway.
This patch removes this entire redundant query, cleaning up the code and
improving the performance of hosts/{hostId}/storage and
hosts/{hostId}/storage/{storageId} by a significant factor.
This patch includes:
1. Removing the redundant calls to GetVgList in
BackendHostStorageResource and amending the test accordingly.
2. Removing GetVgListQuery class and the corresponding constant from
VdcQueryType, now that there are no more usages for it.
3. Removing GetVGListVDSCommand, the corresponding constant in
VDSCommandType, the corresponding methods in IVdsServer and its
implementations and the related VGListReturnForXmlRpc class, now that
there are no more usages for it.
Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVgListQuery.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
D
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
D
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
11 files changed, 6 insertions(+), 255 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/48525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>