From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: add validation for vNic profile mappings
......................................................................
engine: add validation for vNic profile mappings
Add validation for vNic profile mappings
in ImportVmFromConfigurationCommand.
Change-Id: I1d66cde99a0182bfde31031a8b0b5ddc034fe8be
Bug-Url:
https://bugzilla.redhat.com/1277675
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingValidator.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/VnicProfileValidator.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingValidatorTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/VnicProfileValidatorTest.java
6 files changed, 268 insertions(+), 5 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/65139
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d66cde99a0182bfde31031a8b0b5ddc034fe8be
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>