Change in ovirt-engine[ovirt-engine-3.4]: core: Disallow RO disks to be attached to VM
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Disallow RO disks to be attached to VM
......................................................................
core: Disallow RO disks to be attached to VM
RO is not supported when using specific inrtefaces when attached to a
VM. These case are already disallowed when creating a disk, yet are
still allowed when attaching a floating disk with these interfaces, or
when updating a disk.
These interface are IDE and iSCSI for a LUN target. This patch adds the
relevant validations to AttachDiskToVmCommand and UpdateVmDiakCommands's CDAs.
Change-Id: Iac2a8e0fbece57cbb6f375a65cc37e7c2bba11cf
Bug-Url: https://bugzilla.redhat.com/1082673
Bug-Url: https://bugzilla.redhat.com/1094288
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/27454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac2a8e0fbece57cbb6f375a65cc37e7c2bba11cf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server