Change in ovirt-engine[master]: core: change the visibility of validation method in RunVmVal...
Roy Golan has submitted this change and it was merged.
Change subject: core: change the visibility of validation method in RunVmValidator
......................................................................
core: change the visibility of validation method in RunVmValidator
The visibility of validation methods in RunVmValidator that should not
be invoked from outside of this class is changed to 'protected'. Those
are the validation methods that gets all the data they need for their
checks as parameters (inversion of control principle, to make them more
testable).
Change-Id: Iee1ef7ed2f812cf929328c8219ed95e98d2959ae
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 34 insertions(+), 38 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee1ef7ed2f812cf929328c8219ed95e98d2959ae
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server