Change in ovirt-engine[master]: webadmin: it is possible to attach the same disk twice
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: it is possible to attach the same disk twice
......................................................................
webadmin: it is possible to attach the same disk twice
Problem happend in the "instance image flow" only. The problem was that the
disks which can not be attached (e.g. the ones already attached) were returned
only from server. But in the instance image flow the disks are first configured
in the new/edit vm dialog and than submitted at once.
Fixed by removing the this disks from the list of disks to be attached.
Change-Id: I3eb3b0608e957c88c98c264e87dbb651b179c8e3
Bug-Url: https://bugzilla.redhat.com/1228975
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesAttachDiskModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java
3 files changed, 63 insertions(+), 11 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42154
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb3b0608e957c88c98c264e87dbb651b179c8e3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org